Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport unzip method in functor typeclass for scala_2.11 #3234

Merged

Conversation

gagandeepkalra
Copy link
Contributor

addresses #3143

@codecov-io
Copy link

codecov-io commented Dec 31, 2019

Codecov Report

Merging #3234 into scala_2.11 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           scala_2.11   #3234      +/-   ##
=============================================
+ Coverage        93.5%   93.5%   +<.01%     
=============================================
  Files             382     383       +1     
  Lines            7147    7149       +2     
  Branches          194     193       -1     
=============================================
+ Hits             6683    6685       +2     
  Misses            464     464
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/functor.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7be5d...4df6869. Read the comment docs.

@gagandeepkalra
Copy link
Contributor Author

If this looks good I can start working on other subtask for #3143

@gagandeepkalra gagandeepkalra changed the title backport unzip method in functor typeclass for scala_2.11 branch Backport unzip method in functor typeclass for scala_2.11 Jan 1, 2020
@gagandeepkalra
Copy link
Contributor Author

I need some help with this error on running docs/makeMicrosite

[error] (docs / Jekyll / mappings) java.io.IOException: Cannot run program "jekyll" (in directory "/Users/gagandeepkalra/IdeaProjects/cats/docs/target/scala-2.11/resource_managed/main/jekyll"): error=2, No such file or directory`

Seems like it's failing for scala_2.11 branch altogether, I'm not very sure how to solve this.

@rossabaker
Copy link
Member

Have you installed jekyll? It's a Ruby utility, and the right way to install it depends on your OS.

@gagandeepkalra
Copy link
Contributor Author

@rossabaker thank you, now I have, and docs/makeMicrosite runs successfully on both my branch and scala_2.11. Now I wonder why is the build failing at all. I tried restarting with a dummy commit (amend) thinking it might just be flaky, but no.

build error,

[error] /home/travis/.rvm/gems/ruby-2.5.3/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:14:in `module:Middleware': uninitialized constant Faraday::Error::ClientError (NameError)
[error] Did you mean? Faraday::ClientError

ends up with.

[error] (docs / Jekyll / mappings) Could not run jekyll, error: 1

@rossabaker
Copy link
Member

It suspect it's related to #3218. There was some recent bitrot in jekyll that broke several projects using sbt-microsites, and it doesn't look like any fix was backported to this branch.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but a more active maintainer in the 2.11 BinCompat Hell Era should look at my shrug below.

core/src/main/scala/cats/syntax/all.scala Show resolved Hide resolved
@travisbrown travisbrown self-requested a review January 7, 2020 10:25
Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thanks.

@rossabaker rossabaker merged commit 7890320 into typelevel:scala_2.11 Jan 7, 2020
@gagandeepkalra gagandeepkalra deleted the backport/functor/unzip branch January 7, 2020 23:41
@gagandeepkalra
Copy link
Contributor Author

Thank you 😊

yangzai pushed a commit to yangzai/cats that referenced this pull request Mar 9, 2020
…3234)

* backported unzip method in functor typeclass

* fixed nonfunctioning doctest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants