More Dotty compat stuff in tests #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisbrown
requested review from
kailuowang,
fthomas,
rossabaker and
LukaJCB
LukaJCB
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, I think I'm really close to cross-compiling the Cats tests on Dotty, and I'm pretty sure this is the last batch of Scala 2-friendly changes that could be merged into master right now. (The rest of the changes are stubs for ScalaTest macros and explicit type parameters for cases where Dotty's type inference is worse than Scala 2's, which I'm working on feature requests for.)
Note that I've changed a few instances of
"code" shouldNot compiletoassertDoesNotCompile("code"), which is both more consistent with Cats's style elsewhere (e.g. usingassertTypeErrorinstead ofshouldNot typeCheck) and easier to temporarily stub for Dotty. In my view this is a strict improvement even on Scala 2 (but I hate ScalaTest's matchers in general).