Adding instances for ArraySeq #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaJCB
reviewed
Jan 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #3273 +/- ##
==========================================
+ Coverage 93.08% 93.12% +0.04%
==========================================
Files 376 378 +2
Lines 7428 7516 +88
Branches 196 196
==========================================
+ Hits 6914 6999 +85
- Misses 514 517 +3
Continue to review full report at Codecov.
|
travisbrown
reviewed
Jan 28, 2020
kernel/src/main/scala-2.13+/cats/kernel/instances/ArraySeqInstances.scala
Outdated
Show resolved
Hide resolved
BalmungSan
changed the title
|
Uhm, I do not understand why this PR decreases the coverture. |
|
@BalmungSan you can check right here https://codecov.io/gh/typelevel/cats/pull/3273/diff which methods currently aren't covered :) Seems like for most of those you can just add more/different law tests |
travisbrown
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at adding common instances for ArraySeq.
I am not sure if we could implement more typeclasses and if the tests are ok. Also, many implementations of the methods were borrowed from the Vector and LazySList ones.
So, any feedback is welcome.
Closes #2994
BTW, I have a surgery this Wednesday. So, if reviewers leave feedback and I do not answer them, and some have the motivation and time to finish this PR, I would really appreciate it. Since, probably I won't touch a computer again until the next week.