Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #2834 Add CommutativeMonoid[Option[A]] instance #3334

Conversation

gagandeepkalra
Copy link
Contributor

addresses #3143

@codecov-io
Copy link

codecov-io commented Feb 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (scala_2.11@0980189). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             scala_2.11    #3334   +/-   ##
=============================================
  Coverage              ?   93.38%           
=============================================
  Files                 ?      385           
  Lines                 ?     7166           
  Branches              ?      193           
=============================================
  Hits                  ?     6692           
  Misses                ?      474           
  Partials              ?        0
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/option.scala 100% <ø> (ø)
.../scala/cats/kernel/instances/OptionInstances.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0980189...83239e1. Read the comment docs.

@travisbrown travisbrown self-requested a review March 2, 2020 08:05
@travisbrown travisbrown merged commit 3d5a5c2 into typelevel:scala_2.11 Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants