Preliminary Munit port #3538
Merged
Preliminary Munit port #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
reviewed
Jul 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #3538 +/- ##
==========================================
- Coverage 91.34% 91.32% -0.02%
==========================================
Files 386 386
Lines 8592 8592
Branches 241 269 +28
==========================================
- Hits 7848 7847 -1
- Misses 744 745 +1 |
larsrh
reviewed
Jul 29, 2020
| @@ -126,6 +127,7 @@ lazy val commonJsSettings = Seq( | |||
| jsEnv := new org.scalajs.jsenv.nodejs.NodeJSEnv(), | |||
| // batch mode decreases the amount of memory needed to compile Scala.js code | |||
| scalaJSLinkerConfig := scalaJSLinkerConfig.value.withBatchMode(isTravisBuild.value), | |||
| scalaJSLinkerConfig ~= (_.withModuleKind(ModuleKind.CommonJSModule)), | |||
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
I honestly don't know, but the error message I got when running the tests without it pointed me to this. 😄
barambani
reviewed
Jul 29, 2020
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
|
Thanks for those, I think unblocking the dotty work is more important than fixing all the style issues for now, but I'm sure some regex master could fix this for us at some point 😄 |
barambani
approved these changes
Jul 30, 2020
For sure. Let's ship this 🚀 |
|
Alright, merging this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #3534