Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test freeJS with FastOptStage to save some CO2 #3548

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

joroKr21
Copy link
Member

@joroKr21 joroKr21 commented Aug 3, 2020

No description provided.

Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But but… it's already in the cloud!

Copy link
Contributor

@barambani barambani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

Merging #3548 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3548      +/-   ##
==========================================
+ Coverage   91.32%   91.40%   +0.07%     
==========================================
  Files         386      386              
  Lines        8592     8540      -52     
  Branches      269      241      -28     
==========================================
- Hits         7847     7806      -41     
+ Misses        745      734      -11     

@barambani barambani merged commit 84c2e76 into typelevel:master Aug 4, 2020
@joroKr21
Copy link
Member Author

joroKr21 commented Aug 4, 2020

Hmm I didn't see any difference - but now we should be able to run all JS tests concurrently - I will try that next.

@joroKr21 joroKr21 deleted the free-fast branch August 4, 2020 04:16
@joroKr21
Copy link
Member Author

joroKr21 commented Aug 4, 2020

It could also depend on the node version / OS - we use a really old one on Travis (4)

@djspiewak
Copy link
Member

Btw, doing a bit of digging… I think this setting is defaulted.

@joroKr21
Copy link
Member Author

joroKr21 commented Aug 5, 2020

but now we should be able to run all JS tests concurrently - I will try that next.

Done in #3546 - it works

@travisbrown travisbrown added this to the 2.2.0-RC3 milestone Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants