Deprecate ifA. #3893
Merged
Deprecate ifA. #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
previously approved these changes
May 18, 2021
LukaJCB
previously approved these changes
May 18, 2021
|
This is failing because of some problems in |
|
Were those problems fixed? I see main is passing. Do we just need a merge/rebase? |
The ifA method has been discussed as dangerous and misleading, because executing the effects of _both_ branches is hardly ever desirable. Proposed in Issue #3889 Instead, users of this method should use either the `ifM` method of the `FlatMap` class (when each branch is an effect) or the `ifF` method of the `Functor` class (where each branch is a value).
Ammended, rebased, and pushed. Sadly, reviews are lost. Could you look again? |
rossabaker
approved these changes
May 22, 2021
djspiewak
approved these changes
May 30, 2021
Comment on lines
+228
to
229
| @deprecated("Dangerous method, use ifM (a flatMap) or ifF (a map) instead", "2.6.2") | ||
| def ifA[A](fcond: F[Boolean])(ifTrue: F[A], ifFalse: F[A]): F[A] = { |
There was a problem hiding this comment.
We can also eventually make this package private, shutting off the source access without breaking bincompat. We should wait a while though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, a year and a half ago, somebody thought that having an
ifAmethod, an applicative counterpart of theifMmethod fromFlatMap(or M for Monad), would be a good idea. Turns out, having an "If-then-else" that actually performs both effects is hardly ever desirable, but the name naturally suggests it would not, so that was quite misleading. This has tripped some people. Thus the time has come to deprecate it, and retire it soon.Resolves #3889