-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @implicitNotFound
annotations
#4060
Remove @implicitNotFound
annotations
#4060
Conversation
@implicitNotFound
annotations
I am for it in general – such annotations should not be necessary. It is a compiler's job after all to provide us with meaningful error messages. I guess this annotation itself was invented in Scala long ago to alleviate some compiler weaknesses at that time. But could we double check please what the error messages look like with this change in some relatively sophisticated cases for all Scala versions we support? Just to make sure we don't make things worse. |
I think this annotation is still useful, if you want to provide additional context (e.g., how to get that implicit). That seems to have been the original goal in #581, although it was never executed (?) and isn't relevant anymore anyway. But just saying what is missing is something the compiler does anyway, and I think (hope) has been doing for a while? :) I tried some simple examples with a scastie in #4059 (comment) but not sure if that covers our concerns. |
Yeah I think this actually makes the error messages better because we get the fully-qualified names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Thanks for looking into it.
Find/replace fix for #4059.