Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-scalajs, scalajs-compiler, ... to 1.8.0 #4082

Closed

Conversation

scala-steward
Copy link
Contributor

Updates

from 1.7.1 to 1.8.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-js" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armanbilge as ScalaJS-guru, what do you think about having this? Would this mean we need a major release when merging?

@armanbilge
Copy link
Member

Merging this would require a minor version bump, i.e. cats 2.8.0. Seems we've already done that actually.

There was a short-lived attempt to pin the Scala.js version to 1.5.1 in #4018, then we joined team upgrade. So let's go ahead with this.

@armanbilge
Copy link
Member

BTW, here is one way a project can get stuck on Scala.js 1.7.x: mdoc.js currently does not work for Scala.js 1.8.0 (see scalameta/mdoc#590) and fixing it has proven to be non-trivial (see scalameta/mdoc#597). So until that's resolved I can't merge http4s/http4s-dom#60 without breaking the website.

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I changed my mind. Other projects are having trouble upgrading as well such as outwatch/outwatch#551 and the problem with mdoc.js has proven harder to fix than I expected.

@scala-steward
Copy link
Contributor Author

Superseded by #4132.

@scala-steward scala-steward deleted the update/sbt-scalajs-1.8.0 branch February 14, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants