-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typeclasses.md #4325
Update typeclasses.md #4325
Conversation
Update the infographic to modern cats/cats-effect versions
Fix link
thanks for doing this. I haven't reviewed all the links, but when I view the new svg I see Bimonad arrow to Monad going to the center of the Monad node, not the edge, like the other cases. Do you see that? Secondly, I think the URL should be a URL that typelevel controls, not a user (so even the tpolecat URL had this problem). I wonder if we could just commit the SVG to the ghpages branch for this repo? I'm not very experienced with all the issues with that here though. |
Totally 👍 for that. It is quite annoying that even having all the doc sources fetched in a local repo we still have to fetch the SVG (which is supposed to be a part of the docs) from elsewhere. I wonder though, how is that SVG got generated? Can we integrate it with the docs build somehow? |
See https://github.com/tpolecat/cats-infographic It appears to be an "OmniGraffle" file. Might be complicated to integrate into the build. |
Laika will hopefully be getting support for Mermaid diagrams soon.
Maybe we can make a similar diagram using that. |
Thanks for comments, I'll try to update graph and move it to this repo later |
bc04879
to
72fb145
Compare
Hi. |
@tsobako fyi: in Cats 2.7.0 there was
UPD. Looking at the diagram I am not sure if it is easy to squeeze |
Hi. |
Hi. |
Seems like this PR got stuck for some reason. I think it is because the most recent CI failed. Just wondering, is it failing due to issues with the update itself or is it just due to CI flakiness? |
It's CI flake. But I think this PR is blocked until Laika supports Mermaid. |
@tsobako see some discussion/commentary in #4374 (comment). |
Update the infographic to modern cats/cats-effect versions
Thank you for contributing to Cats!
This is a kind reminder to run
sbt +prePR
and commit the changed files, if any, before submitting.