Add more doctest to Monad and FlatMap
#4427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
changed the title
Monad and FlatMap
johnynek
reviewed
May 17, 2023
armanbilge
reviewed
Jun 26, 2023
core/src/main/scala/cats/Monad.scala
Outdated
Comment on lines
49
to
53
| * scala> val appendStr: StateT[Id, String, Unit] = StateT.modify(_ + "a") | ||
| * scala> val appendStrAndGet: StateT[Id, String, String] = appendStr *> StateT.get | ||
| * scala> val (result, agg) = appendStrAndGet.whileM[Vector](StateT.inspect(i => !(i.length >= 5))).run("") | ||
| * result: String = aaaaa | ||
| * agg: Vector[String] = Vector(a, aa, aaa, aaaa, aaaaa) |
There was a problem hiding this comment.
Instead of StateT[Id, ...] can't we just use State? The issue with StateT[Id, ...] is that actually it is not stacksafe.
There was a problem hiding this comment.
Sure, should I use State also in all other examples that uses StateT or just this one?
There was a problem hiding this comment.
Yes. You should never use StateT[Id.
There was a problem hiding this comment.
Done. I'm using State now, but there's some results that's previous result + 1, like in iterateUntilM. Is that okay?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for part of #2479
Adding doctest for
MonadandFlatMaptypeclasses.