Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raiseWhen/raiseUnless convenience methods to EitherObjectOps #4436

Merged
merged 2 commits into from
May 13, 2023
Merged

Add raiseWhen/raiseUnless convenience methods to EitherObjectOps #4436

merged 2 commits into from
May 13, 2023

Conversation

Daenyth
Copy link
Contributor

@Daenyth Daenyth commented May 11, 2023

Similar to the ones for IO

@satorg
Copy link
Contributor

satorg commented May 11, 2023

Thank you for the PR!
Would it be possible to add a couple of tests for the new methods please?

I think this file could be a good place for it:

cats/tests/shared/src/test/scala/cats/tests/EitherSuite.scala

Line 37 in d5f7d63

class EitherSuite extends CatsSuite {

@Daenyth
Copy link
Contributor Author

Daenyth commented May 12, 2023

@satorg Done

armanbilge
armanbilge approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@armanbilge armanbilge changed the title Add raiseWhen/raiseUnless convenience methods to EitherObjectOps Add raiseWhen/raiseUnless convenience methods to EitherObjectOps May 12, 2023
satorg
satorg approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@danicheg danicheg merged commit 8473a37 into typelevel:main May 13, 2023
@Daenyth Daenyth deleted the either-raisewhen branch May 16, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satorg satorg satorg approved these changes

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Daenyth @satorg @armanbilge @danicheg