Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add xorMonoid #521

Merged
merged 1 commit into from
Sep 10, 2015
Merged

add xorMonoid #521

merged 1 commit into from
Sep 10, 2015

Conversation

drostron
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 63.82%

Merging #521 into master will increase coverage by +0.02% as of 53846b6

@@            master    #521   diff @@
======================================
  Files          155     155       
  Stmts         2365    2366     +1
  Branches        66      66       
  Methods          0       0       
======================================
+ Hit           1509    1510     +1
  Partial          0       0       
  Missed         856     856

Review entire Coverage Diff as of 53846b6

Powered by Codecov. Updated on successful CI builds.

adelbertc
adelbertc reviewed Sep 10, 2015
View reviewed changes
tests/shared/src/test/scala/cats/tests/XorTests.scala
@@ -12,6 +13,8 @@ import org.scalacheck.Arbitrary._
import scala.util.Try

class XorTests extends CatsSuite {
checkAll("Xor[String, Int]", algebra.laws.GroupLaws[Xor[String, Int]].monoid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check Serializability

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - Xor[String, Int].monoid.serializable in the test output. It appears serializability is checked via:

https://github.com/non/algebra/blob/v0.3.1/laws/shared/src/main/scala/algebra/laws/GroupLaws.scala#L28

Is that sufficient or is there a reason to have the following in addition?

checkAll("Xor[String, Int]", SerializableTests.serializable(Monoid[Xor[String, Int]]))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you're right, algebra includes Serializable checks in their laws - @non confirm?

@adelbertc
Copy link
Contributor

👍

1 similar comment
@non
Copy link
Contributor

non commented Sep 10, 2015

👍

non added a commit that referenced this pull request Sep 10, 2015
@non
Merge pull request #521 from drostron/xor-monoid-instance
a89d71e 
add xorMonoid
@non non merged commit a89d71e into typelevel:master Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drostron @codecov-io @adelbertc @non