Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fromOption to OptionT #528

Merged
merged 1 commit into from
Sep 13, 2015
Merged

Add fromOption to OptionT #528

merged 1 commit into from
Sep 13, 2015

Conversation

frosforever
Copy link
Contributor

Strikingly similar to fromXor found in XorT, this adds fromOption to OptionT wrapping the Option in the appropriate applicative.

@codecov-io
Copy link

Current coverage is 64.58%

Merging #528 into master will increase coverage by +0.07% as of 4b556ec

@@            master    #528   diff @@
======================================
  Files          157     157       
  Stmts         2421    2423     +2
  Branches        66      66       
  Methods          0       0       
======================================
+ Hit           1562    1565     +3
  Partial          0       0       
+ Missed         859     858     -1

Review entire Coverage Diff as of 4b556ec

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Sep 12, 2015

👍

@non
Copy link
Contributor

non commented Sep 12, 2015

Great catch, thanks for making things consistent.

One tiny request: can you reformat your scaladoc comments? In Cats we have been using:

/**
 *
 */

(I.e. the stars align on the left not the right.)

Once that issue is resolved, 👍 from me too.

@frosforever
Copy link
Contributor Author

@non Done.

@ceedubs
Copy link
Contributor

ceedubs commented Sep 13, 2015

Thanks, @frosforever!

ceedubs added a commit that referenced this pull request Sep 13, 2015
@ceedubs ceedubs merged commit e507b24 into typelevel:master Sep 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants