Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax for validated. #587

Merged
merged 1 commit into from
Oct 27, 2015

Conversation

coltfred
Copy link
Contributor

Add syntax to values for lifting them into Valid, Invalid and the Nel versions of those. Currently no tests as I was unable to figure out which mechanism was preferred for testing syntax.

Let me know how that should be done.

Addresses #585.

@codecov-io
Copy link

Current coverage is 75.97%

Merging #587 into master will decrease coverage by -0.31% as of 3f003e7

@@            master    #587   diff @@
======================================
  Files          158     159     +1
  Stmts         2172    2181     +9
  Branches        68      68       
  Methods          0       0       
======================================
  Hit           1657    1657       
  Partial          0       0       
- Missed         515     524     +9

Review entire Coverage Diff as of 3f003e7

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Oct 27, 2015

👍

I would vote for merging this and creating a separate issue for testing syntax. And possibly another one for whether we should be using Eval instead of by-name params for these?

@ceedubs
Copy link
Contributor

ceedubs commented Oct 27, 2015

By the way, thanks @coltfred!

@julien-truffaut
Copy link
Contributor

👍 I agree with @ceedubs we should discuss Eval and test in a separate issue

julien-truffaut added a commit that referenced this pull request Oct 27, 2015
@julien-truffaut julien-truffaut merged commit 1671a8d into typelevel:master Oct 27, 2015
@coltfred
Copy link
Contributor Author

No problem!

@coltfred coltfred deleted the validatedSyntax branch October 27, 2015 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants