Remove Validated.filter #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was leftover from copy/paste from `Xor`. It mentions that it's useful when using `Validated` in for-comprehensions, but you can't actually use `Validated` in for-comprehensions since it doesn't have a `flatMap` method :). Also, `Xor` no longer has a `filter` method. It was removed in typelevel#276 since using the monoid zero when the predicate doesn't match is rather arbitrary and can lead to surprises. I think we should follow that precedent for `Validated`.
Current coverage is
|
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was leftover from copy/paste from
Xor. It mentions thatit's useful when using
Validatedin for-comprehensions, but you can'tactually use
Validatedin for-comprehensions since it doesn't have aflatMapmethod :).Also,
Xorno longer has afiltermethod. It was removed in #276since using the monoid zero when the predicate doesn't match is rather
arbitrary and can lead to surprises. I think we should follow that
precedent for
Validated.