Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check more Eval instance laws #636

Merged
merged 1 commit into from
Nov 15, 2015
Merged

Check more Eval instance laws #636

merged 1 commit into from
Nov 15, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Nov 14, 2015

This makes Eval serializable and adds law-checking for its Group, Monoid,
Semigroup, Order, PartialOrder, and Eq instances.

Fixes #630.

@ceedubs
Check more Eval instance laws
7298ecf 
This makes `Eval` serializable and adds law-checking for its `Group`, `Monoid`,
`Semigroup`, `Order`, `PartialOrder`, and `Eq` instances.

Fixes typelevel#630.
@codecov-io
Copy link

Current coverage is 77.07%

Merging #636 into master will increase coverage by +0.72% as of d6b1e10

@@            master    #636   diff @@
======================================
  Files          159     159       
  Stmts         2081    2081       
  Branches        70      70       
  Methods          0       0       
======================================
+ Hit           1589    1604    +15
  Partial          0       0       
+ Missed         492     477    -15

Review entire Coverage Diff as of d6b1e10

Powered by Codecov. Updated on successful CI builds.

@non
Copy link
Contributor

non commented Nov 14, 2015

👍 rockstar 🎸 🔈 🎶

@adelbertc
Copy link
Contributor

👍

adelbertc added a commit that referenced this pull request Nov 15, 2015
@adelbertc
Merge pull request #636 from ceedubs/eval-laws
ff359d7 
Check more Eval instance laws
@adelbertc adelbertc merged commit ff359d7 into typelevel:master Nov 15, 2015
@ceedubs ceedubs deleted the eval-laws branch November 15, 2015 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ceedubs @codecov-io @non @adelbertc @fthomas