-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic/arrow scaladoc #797
Topic/arrow scaladoc #797
Conversation
Looks great to me. 👍 I think that Travis error is spurious, we should retry it. |
def dimap[A, B, C, D](fab: F[A, B])(f: C => A)(g: B => D): F[C, D] = | ||
compose(lift(g), andThen(lift(f), fab)) | ||
|
||
/** | ||
* Create a new arrow that takes two inputs, but only modifies the second input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: only modifies the first input
Thanks, @lukewyman! Just one minor typo, and otherwise this looks great. |
Current coverage is
|
pushed a change to fix the typo on Arrow.first |
Thanks! 👍 |
Work for #788. Added Scaladoc comments for cats/arrow/Arrow.scala.