Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Applicative syntax #884

Merged
merged 1 commit into from
Feb 24, 2016
Merged

Conversation

notxcain
Copy link
Contributor

This PR adds Applicative syntax. Fixes #882.
Not sure if I should test for Applicative#traverse and Applicative#sequence.
I don’t know if simulacrum generates anything for these methods.

@codecov-io
Copy link

Current coverage is 88.90%

Merging #884 into master will decrease coverage by -0.15% as of 4a53488

@@            master   #884   diff @@
=====================================
  Files          174    175     +1
  Stmts         2384   2388     +4
  Branches        76     76       
  Methods          0      0       
=====================================
  Hit           2123   2123       
  Partial          0      0       
- Missed         261    265     +4

Review entire Coverage Diff as of 4a53488

Powered by Codecov. Updated on successful CI builds.

@adelbertc
Copy link
Contributor

👍

@notxcain
Copy link
Contributor Author

@adelbertc if there is nothing valuable in Ops generated by simulacrum, maybe it worth completely removing conversion to Ops?

@adelbertc
Copy link
Contributor

Sounds good with me. And merge conflicts

@notxcain
Copy link
Contributor Author

@adelbertc done!

@stew
Copy link
Contributor

stew commented Feb 24, 2016

👍

stew added a commit that referenced this pull request Feb 24, 2016
@stew stew merged commit 4820a0c into typelevel:master Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants