Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Unapply serializable #905

Merged
merged 1 commit into from
Mar 1, 2016
Merged

make Unapply serializable #905

merged 1 commit into from
Mar 1, 2016

Conversation

kailuowang
Copy link
Contributor

This will enable typeclasses that uses Unapply to be serializable themselves.

@ceedubs
Copy link
Contributor

ceedubs commented Mar 1, 2016

Thanks, @kailuowang. Could you please add a test (probably something like

checkAll("Bimonad[Function0]", SerializableTests.serializable(Bimonad[Function0]))
)?

@kailuowang
Copy link
Contributor Author

@ceedubs test added.

@adelbertc
Copy link
Contributor

👍 on Travis green

@codecov-io
Copy link

Current coverage is 89.59%

Merging #905 into master will increase coverage by +0.04% as of 9f5602a

@@            master    #905   diff @@
======================================
  Files          181     181       
  Stmts         2423    2423       
  Branches        76      76       
  Methods          0       0       
======================================
+ Hit           2170    2171     +1
  Partial          0       0       
+ Missed         253     252     -1

Review entire Coverage Diff as of 9f5602a

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Mar 1, 2016

👍 thanks!

ceedubs added a commit that referenced this pull request Mar 1, 2016
@ceedubs ceedubs merged commit c292e7f into typelevel:master Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants