Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off scaladoc generation for Scala 2.10 due to macro problems #958

Merged
merged 1 commit into from
Mar 28, 2016

Conversation

mikejcurry
Copy link
Contributor

This PR would switch off scaladoc generation for Scala 2.10 during the makeSite process. The site generated in 2.10 mode would not have scaladoc generated, but would be otherwise identical to the site generated in 2.11 mode.

This allows documentation to be put together for all classes, and should allow #898 to pass the build.

@ceedubs
Copy link
Contributor

ceedubs commented Mar 28, 2016

Sounds good to me if it should fix #898. Thanks!

@codecov-io
Copy link

Current coverage is 89.78%

Merging #958 into master will not affect coverage as of 960a9ed

@@            master    #958   diff @@
======================================
  Files          180     180       
  Stmts         2144    2144       
  Branches        42      42       
  Methods          0       0       
======================================
  Hit           1925    1925       
  Partial          0       0       
  Missed         219     219       

Review entire Coverage Diff as of 960a9ed

Powered by Codecov. Updated on successful CI builds.

@rossabaker
Copy link
Member

I did the same for http4s for the same reason, and haven't had any regrets.

@ceedubs ceedubs merged commit 58362c2 into typelevel:master Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants