Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scala Native 0.4 #73

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Jan 24, 2021

No description provided.

Copy link

@arashi01 arashi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually compile for you for Scala 2.13 and 2.12? Scala versions need a bump to 2.13.4 and 2.12.13 respectively to work with Scala Native 0.4.0 due to availability of nscplugin.

Also native project needs to be disabled for Dotty builds.

And native project has not been added to aggregate root build.

- Update Scala 2.12 to 2.12.13
- Update Scala 2.13 to 2.13.4
@lolgab
Copy link
Contributor Author

lolgab commented Jan 27, 2021

And native project has not been added to aggregate root build.

Not adding it to the root aggregate tricked me!
Sorry for that. You're completely right.

arashi01 added a commit to arashi01/cats that referenced this pull request Jan 29, 2021
@larsrh larsrh self-assigned this Jan 29, 2021
@larsrh larsrh merged commit c873db6 into typelevel:master Jan 30, 2021
@larsrh
Copy link
Contributor

larsrh commented Jan 30, 2021

Thanks a lot! Let's see if we can get a release out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants