Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed name of the implicit val defining the function for the Get and Write types #1598

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Fixed name of the implicit val defining the function for the Get and Write types #1598

merged 2 commits into from
Dec 10, 2021

Conversation

rcardin
Copy link
Contributor

@rcardin rcardin commented Nov 23, 2021

This PR addresses issue #1597.

Let me know if I understood it wrong.

@jatcwang jatcwang assigned jatcwang and unassigned jatcwang Nov 24, 2021
@rcardin rcardin changed the title Fixed name of the implicit val defining the function for the Get type Fixed name of the implicit val defining the function for the Get and Write types Nov 25, 2021
jatcwang
jatcwang approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@jatcwang jatcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This does break binary compatibility but since we're in RC I think this is fine.

@jatcwang jatcwang merged commit 7aec31f into typelevel:main Dec 10, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatcwang jatcwang jatcwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcardin @jatcwang