Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lambda-otel4s module #459

Open
wants to merge 67 commits into
base: main
Choose a base branch
from

Conversation

alexcardell
Copy link

@alexcardell alexcardell commented Feb 23, 2024

Supercedes #456

  • Adds lambda-natchez module
  • Adds lambda-otel4s module
    • Traces lambdas with semantic conventions applied
  • Adds otel4s examples
  • Add scalafix migration to port natchez package imports -- (removes previous version scalafix migrations)

This is targeting otel4s 0.10.0

Links

https://opentelemetry.io/docs/specs/semconv/faas/aws-lambda/
https://opentelemetry.io/docs/specs/semconv/faas/faas-spans/

@alexcardell
Copy link
Author

Currently pointed at a local snapshot so CI will definitely fail, as otel4s main has NoPublish for everything involving the SDK

@alexcardell alexcardell marked this pull request as ready for review March 12, 2024 19:21
@alexcardell alexcardell changed the title WIP: Add lambda-otel4s module Add lambda-otel4s module Mar 12, 2024
@alexcardell
Copy link
Author

@iRevive Updated all the attributes and removed semconv-experimental

Would appreciate another look when you have time

@iRevive
Copy link

iRevive commented Apr 20, 2024

@alexcardell the changes look good.

We still need to wait for a release of https://github.com/http4s/http4s-otel4s-middleware, right?

@alexcardell
Copy link
Author

The middleware would be useful for the example, but I don't believe it's necessary otherwise

@armanbilge
Copy link
Member

There are also some AWS goodies in the upcoming 0.10.0 otel4s release (for otel4s-sdk):

@iRevive is v0.10.0 coming soon?

import feral.lambda.natchez.KernelSource
import org.typelevel.ci._

protected trait KernelSources {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of putting these in the package object, we can put them in the companion object for KernelSource. Then they will automatically be in implicit scope without an import.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcardell Can you look into this as well? 🙏

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armanbilge done :)

@iRevive
Copy link

iRevive commented Sep 22, 2024

There are also some AWS goodies in the upcoming 0.10.0 otel4s release (for otel4s-sdk):

@iRevive is v0.10.0 coming soon?

We are two PRs away from 0.10.0:

Both are implemented, some minor changes (docs, etc) may be required.

I think we will have 0.10.0 next week.

@armanbilge
Copy link
Member

I am going hang on for otel4s v0.10.0 to avoid back-to-back breaking releases!

@iRevive
Copy link

iRevive commented Sep 24, 2024

0.10.0 is out. It should be a straightforward update.

@armanbilge
Copy link
Member

so fast!!

@alexcardell
Copy link
Author

Updated

build.sbt Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@iRevive
Copy link

iRevive commented Oct 9, 2024

There is a compatible pre-release of the http4s-otel4s - https://github.com/http4s/http4s-otel4s-middleware/releases/tag/v0.9.0-rc.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants