-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lambda-otel4s module #459
base: main
Are you sure you want to change the base?
Conversation
6b6999d
to
4242256
Compare
Currently pointed at a local snapshot so CI will definitely fail, as otel4s main has |
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/FaasAttributes.scala
Outdated
Show resolved
Hide resolved
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/TracedHandler.scala
Outdated
Show resolved
Hide resolved
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/package.scala
Outdated
Show resolved
Hide resolved
@iRevive Updated all the attributes and removed semconv-experimental Would appreciate another look when you have time |
@alexcardell the changes look good. We still need to wait for a release of https://github.com/http4s/http4s-otel4s-middleware, right? |
The middleware would be useful for the example, but I don't believe it's necessary otherwise |
This is to allow consumers the choice of natchez or otel4s No breaking changes except requiring a `feral.lambda.natchez._` import
Co-authored-by: Maksym Ochenashko <maxochenashko@gmail.com>
@iRevive is v0.10.0 coming soon? |
import feral.lambda.natchez.KernelSource | ||
import org.typelevel.ci._ | ||
|
||
protected trait KernelSources { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of putting these in the package object, we can put them in the companion object for KernelSource
. Then they will automatically be in implicit scope without an import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcardell Can you look into this as well? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@armanbilge done :)
We are two PRs away from 0.10.0: Both are implemented, some minor changes (docs, etc) may be required. I think we will have 0.10.0 next week. |
I am going hang on for otel4s v0.10.0 to avoid back-to-back breaking releases! |
|
so fast!! |
Updated |
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/TracedHandler.scala
Outdated
Show resolved
Hide resolved
lambda-otel4s/jvm/src/test/scala/feral/lambda/otel4s/TracedHandlerSuite.scala
Outdated
Show resolved
Hide resolved
eb990d6
to
bb2970f
Compare
There is a compatible pre-release of the http4s-otel4s - https://github.com/http4s/http4s-otel4s-middleware/releases/tag/v0.9.0-rc.2. |
Supercedes #456
This is targeting otel4s 0.10.0
Links
https://opentelemetry.io/docs/specs/semconv/faas/aws-lambda/
https://opentelemetry.io/docs/specs/semconv/faas/faas-spans/