Reimplement PipedInput/OutputStream #2383
Conversation
|
The failing tests are already addressed in #2373. |
| * | ||
| * @param capacity the capacity of the allocated circular buffer | ||
| */ | ||
| private[io] final class InputOutputBuffer(private[this] val capacity: Int) { self => |
There was a problem hiding this comment.
One general question: given that this entire class only depends on Java libraries, could it be submitted for the Scala standard library? Sys or process.
| private[this] var closed: Boolean = false | ||
|
|
||
| private[this] val readerPermit: Semaphore = new Semaphore(1) | ||
| private[this] val writerPermit: Semaphore = new Semaphore(1) |
There was a problem hiding this comment.
Could you add a summary of how these permits are used? Are their values ever > 1?
There was a problem hiding this comment.
I believe they can be > 1 at some point, they are not completely foolproof, they are just here to prevent threads from looping endlessly when there is nothing to be read from the buffer. This is fine, because there is one more monitor, the self.synchronized block, which actually guards the critical section. Does this make any sense?
There was a problem hiding this comment.
Okay cool. My only concern is that some strange access pattern could result in writerPermit getting very large, which then causes lots of looping when waiting to write.
There was a problem hiding this comment.
Ok, let's not rush this, I will reiterate on the code.
There was a problem hiding this comment.
I implemented a custom synchronizer that allows at most 1 permit at any time.
|
Wow the |
Resolves #2037. I included the original reproduction as a test.
This was not pleasant to write.