New cross platform APIs in fs2.io.file #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8dcd3ce.
Implement Files for js
file2: platform-independent walk
file2: Path semantics matching, tests, docs
Implement createFile for Node.js
Implement symbolic link for JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the
fs2.io.filepackage made heavy use of types fromjava.nio.file-- most notablyPath. This makes cross building for Node.js difficult and also results in an API that's unfamiliar for folks who haven't usedjava.nio.file, with various Java-isms (e.g.StandardOpenOptions).This PR deprecates the old APIs and introduces new ones with no dependencies on
java.nio.file. This is done in a way that preserves binary compatibility.