Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text.lines enhancements #2758

Merged
merged 12 commits into from
Dec 22, 2021
Merged

text.lines enhancements #2758

merged 12 commits into from
Dec 22, 2021

Commits on Dec 17, 2021

  1. text.lines enhancements: 

    * add support for input with '\r'-only newlines, like from macos classic. yes, content like this still exists
* add support to throw an error when an accumulated line is over a certain size; good to prevent bad/malicious inputs from causing OOMs
    @stephenjudkins
    stephenjudkins committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    a6c6b01 View commit details
    Browse the repository at this point in the history

  2. Fix docs, change some param names

    @stephenjudkins
    stephenjudkins committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    a56fe21 View commit details
    Browse the repository at this point in the history

  3. format

    @stephenjudkins
    stephenjudkins committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    6e503a4 View commit details
    Browse the repository at this point in the history

  4. scalafmt

    @stephenjudkins
    stephenjudkins committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    e05d9b2 View commit details
    Browse the repository at this point in the history

  5. scalafmt

    @stephenjudkins
    stephenjudkins committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    601e72c View commit details
    Browse the repository at this point in the history

  6. Fix for scala 2.12 build

    @stephenjudkins
    stephenjudkins committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    9d46873 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2021

  1. Use custom exception for too-long line

    @stephenjudkins
    stephenjudkins committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    f6adcbe View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. Don't use deprecated method, for good measure. 

    I haven't run any benchmarks but this should avoid a copy, at least
    @stephenjudkins
    stephenjudkins committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    960e1fc View commit details
    Browse the repository at this point in the history

  2. Scala 2.12 fix, again

    @stephenjudkins
    stephenjudkins committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    f54d4fd View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Test that existing CRLF-delimited text is split appropriately when `c… 

    …rsOnly` is enabled
    @stephenjudkins
    stephenjudkins committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    68a2a59 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Always split lines on '\r'-delimited input; simplify methods

    @stephenjudkins
    stephenjudkins committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    774cb3b View commit details
    Browse the repository at this point in the history

  2. unsure how that compiled

    @stephenjudkins
    stephenjudkins committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    e8c89f2 View commit details
    Browse the repository at this point in the history