Stream - reimplement without Pull.loop #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diesalbla
force-pushed
the
stream_fewer_Pull_loop
branch
from
e2e5b15
to
fc6a188
Compare
mpilquist
reviewed
Feb 28, 2023
The methods unfoldLoop, unfoldLoopEval, and repeatPull, are written using the `Pull.loop` function. While this is a nice recursion scheme, a lower-order code variant may be more readable and efficient.
diesalbla
force-pushed
the
stream_fewer_Pull_loop
branch
from
fc6a188
to
d23dcef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods unfoldLoop, unfoldLoopEval, and repeatPull, are written using the
Pull.loopfunction. While this is a nice recursion scheme, a lower-order code variant may be more readable and efficient.