Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework SQL compiler #152

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Rework SQL compiler #152

merged 2 commits into from
Jul 12, 2021

Conversation

milessabin
Copy link
Member

  • Complete rewrite of the SQL compiler.
  • Removed SQL staging logic now that GraphQL queries are mapped to single SQL queries. It's conceivable we might and to reintroduce this later to support non-Postgres DBs.
  • Factored out compiler/interpreter position into a Context type which holds path, result path and type.
  • Unique now just converts [T] to T.
  • Removed Project now that multi-step predicate paths are now supported correctly.
  • Removed GroupBy query algebra term which was only used for (now removed) staging.
  • Codec/Encoder type parameter removed.
  • Added order independent result testing utility.
  • Bumped dependencies to most recent CE2 versions.
  • Added local Docker compose for experimentation.

@milessabin milessabin requested a review from tpolecat July 10, 2021 15:47
@milessabin milessabin self-assigned this Jul 10, 2021
+ Complete rewrite of the SQL compiler.
+ Removed SQL staging logic now that GraphQL queries are mapped to
  single SQL queries. It's conceivable we might and to reintroduce this
  later to support non-Postgres DBs.
+ Factored out compiler/interpreter position into a Context type which
  holds path, result path and type.
+ Unique now just converts [T] to T.
+ Removed Project now that multi-step predicate paths are now supported
  correctly.
+ Removed GroupBy query algebra term.
+ Codec/Encoder type parameter removed.
+ Added order independent result testing utility.
+ Added local Docker compose for experimentation.
@milessabin
Copy link
Member Author

Rebased to pick up the commit missed from main 🙄

Copy link
Member

@tpolecat tpolecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Looking forward to trying it out :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants