Added support for non-root effects #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milessabin
force-pushed
the
topic/non-root-effects-redux
branch
from
a710da0
to
32a94b6
Compare
tpolecat
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
This looks great and I think it will cover our immediate needs. 👍 🎉
I do have a few general questions (inline and below).
There will be some confusion about RootEffect vs. EffectMapping, so could you say a little bit about their differences and when you should use one vs. the other? For instance is the RootEffect.computeCursor case subsumed by EffectMapping?
The example here computes a CirceCursor, but would it be possible to compute a SqlCursor, if for example you need to do intermediate web request in order to gather parameters for a follow-on SQL query? If so, an example would be helpful.
Thanks!
+ Added EffectMapping with one-shot and batched variants. + Added EffectHandler type and Effect node to the query algebra. + Added EffectElaborator phase which maps selections of effect-mapped fields into Effect nodes. + Generalized StagedJson to EffectJson, handling both components and batched effects. + Simplified effect/stage grouping/batching logic. + Renamed and simplified Mapping#combineQueries to combineAndRun. This also replace QueryInterpreter#runRootValues which has been removed. + Several root APIs (eg. defaultRootCursor) which were previously parameterized with a Type and/or an Env are now parameterized with an optional parent Cursor. This allows for more uniform inheritance of runtime attributes between components. + Removed redundant Defer node from the query algebra. + Reordered the argument to the component join for consistency.
+ Renamed EffectMapping to EffectField. + Added scaladoc for PossiblyRenamedSelect. + Added sqlCursor method similar to circeCursor, valueCursor etc. + Extended test to illustrate making a follow on SQL query driven by values returned from an intermediate service request.
milessabin
force-pushed
the
topic/non-root-effects-redux
branch
from
32a94b6
to
67ce8fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EffectFieldwith one-shot and batched variants.EffectHandlertype andEffectnode to the query algebra.EffectElaboratorphase which maps selections of effect-mapped fields intoEffectnodes.StagedJsontoEffectJson, handling both components and batched effects.Mapping#combineQueriestocombineAndRun. This also replacesQueryInterpreter#runRootValueswhich has been removed.defaultRootCursor) which were previously parameterized with aTypeand/or anEnvare now parameterized with an optional parentCursor. This allows for more uniform inheritance of runtime attributes between components.Defernode from the query algebra.