Move to MUnit and whale-tail #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
milessabin
commented
Jun 5, 2023
milessabin
commented
- All tests reworked in terms of Munit.
- All test (file)names normalised to "suite" from "spec".
- Replaced test-containers with whale-tail to allow cross building for JS and native.
+ All tests reworked in terms of Munit. + All test (file)names normalised to "suite" from "spec". + Replaced test-containers with whale-tail to allow cross building for JS and native.
armanbilge
approved these changes
Jun 5, 2023
Comment on lines
20
to
+21
| // Slow because each usage will open a new socket, but ok for now. | ||
| lazy val pool: Resource[IO, Session[IO]] = | ||
| lazy val pool: Resource[IO, Session[IO]] = { |
There was a problem hiding this comment.
We can replace this with a "resource fixture" that is shared for the entire suite in a follow-up PR.
| password = Some(container.password), | ||
| database = container.databaseName, | ||
| // debug = true, | ||
| host = if (host == "0.0.0.0") "127.0.0.1" else host, |
There was a problem hiding this comment.
Note-to-self to look at this.
|
After this merges I'll work on the JS and Native cross-builds. Thanks, these changes are a big help towards that! |
tpolecat
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.