Cross-build for JS+Native #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Darn. Update: Miles and I chatted on Discord, it seems that skunk-circe is not being used in the failing test. So there's something else going on 🤔 |
armanbilge
commented
Jun 7, 2023
| assert(weaklyEqual(x, y, strictPaths)) | ||
| assert(weaklyEqual(clue(x), clue(y), strictPaths)) |
There was a problem hiding this comment.
Anything wrapped in clue will be printed when the assertion fails, useful for debugging.
Comment on lines
+1562
to
+1563
| // JS treats floats as doubles | ||
| def isJS = Option(System.getProperty("java.vm.name")).contains("Scala.js") |
There was a problem hiding this comment.
This was highly annoying but does the trick ...
milessabin
approved these changes
Jun 8, 2023
| @@ -26,7 +25,7 @@ trait SqlDatabaseSuite extends CatsEffectSuite { | |||
| } | |||
|
|
|||
| def bindPath(path: String): String = | |||
| Path(".").absolute.parent.flatMap(_.parent).flatMap(_.parent).get.toString+"/"+path | |||
| buildinfo.BuildInfo.baseDirectory + "/" + path | |||
There was a problem hiding this comment.
This is much better ... thanks!
Comment on lines
+1562
to
+1563
| // JS treats floats as doubles | ||
| def isJS = Option(System.getProperty("java.vm.name")).contains("Scala.js") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost there, just have to track down a couple things ... :)