Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Directives.isRepeatable to introspection response #440

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

QuitHub
Copy link
Contributor

@QuitHub QuitHub commented Jul 7, 2023

Although at the moment the directives return an empty array, we need to be able to parse a query that asks for all the fields required in the spec, specifically isRepeatable

https://spec.graphql.org/draft/#sec-The-__Directive-Type
https://github.com/graphql/graphql-spec/blame/main/spec/Section%204%20--%20Introspection.md#L500-L502

@QuitHub QuitHub changed the title Adds Directives.isReapeatable to introspection response Adds Directives.isRepeatable to introspection response Jul 7, 2023
@milessabin milessabin self-requested a review July 7, 2023 14:00
@milessabin milessabin self-assigned this Jul 7, 2023
@milessabin milessabin added the enhancement New feature or request label Jul 7, 2023
Copy link
Member

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milessabin
Copy link
Member

Congrats on your first open source PR! 🎉

@milessabin milessabin merged commit a6483c9 into typelevel:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants