Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of empty SQL subobjects (previously represented by a context-free singleton
EmptySqlQuery
) was incorrect in several scenarios.This showed up in particular in mixed mappings where non-SQL fields were nested in SQL objects. This manifested itself as unexpectedly empty arrays of subobjects, or possibly hit previously unimplemented methods of
EmptySqlQuery
. Both are fixed by ensuring that SQL ids are included when we, in effect, "join" a SQL with a non-SQL object.EmptySqlQuery
is now a non-singleton and has a context and the unimplemented methods have been either implemented or removed.