Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add talks link #536

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Add talks link #536

merged 2 commits into from
Dec 20, 2023

Conversation

jatcwang
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56e244b) 73.20% compared to head (e725f2e) 73.22%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   73.20%   73.22%   +0.02%     
==========================================
  Files          32       32              
  Lines        4456     4456              
  Branches      997      997              
==========================================
+ Hits         3262     3263       +1     
+ Misses       1194     1193       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milessabin
Copy link
Member

Good call!

However, README.md is generated from docs/index.md, using mdoc. So the process is to make additions there; then in SBT run repoDocs/mdoc which will update README.md; then commit the result.

@milessabin milessabin self-requested a review December 20, 2023 11:57
@jatcwang
Copy link
Contributor Author

Done :)

Copy link
Member

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milessabin milessabin merged commit 00c226d into typelevel:main Dec 20, 2023
10 checks passed
@jatcwang jatcwang deleted the patch-1 branch December 20, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants