Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semigroup hierarchy derivation for recursive types #401

Closed
wants to merge 2 commits into from
Closed

Fix semigroup hierarchy derivation for recursive types #401

wants to merge 2 commits into from

Conversation

TimWSpence
Copy link
Member

@TimWSpence TimWSpence commented Nov 2, 2021 •
edited
Loading

Fix semigroup hierarchy derivation for recursive types

@joroKr21
Copy link
Member

joroKr21 commented Nov 2, 2021

@TimWSpence did the CI hang? I try to cancel it but it doesn't work. I think this is blocked on typelevel/shapeless-3#40

@TimWSpence
Copy link
Member Author

🤦 thanks @joroKr21, I think I did see that issue and then completely forgot about it. I'll have a proper look through it later

joroKr21
joroKr21 approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@joroKr21 joroKr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should give the same treatment to all product instances

@joroKr21
Copy link
Member

Oh no I think it's still hanging 🤔

@joroKr21 joroKr21 mentioned this pull request Feb 9, 2022
Merged
@joroKr21
Copy link
Member

Superseded by #455

@joroKr21 joroKr21 closed this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joroKr21 joroKr21 joroKr21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimWSpence @joroKr21