Add tests for all derived instances #516
Conversation
joroKr21
changed the title
| case LeafI(i) => Right(i) | ||
| } | ||
|
|
||
| enum EnumK1[A]: |
There was a problem hiding this comment.
Was this meant to be Covariant?
There was a problem hiding this comment.
I think it doesn't matter
| import scala.quoted.* | ||
|
|
||
| /** An opinionated stack of traits to improve consistency and reduce boilerplate in Kittens tests. Note that unlike the | ||
| * corresponding CatsSuite in the Cat project, this trait does not mix in any instances. | ||
| */ | ||
| abstract class KittensSuite extends KittensSuite.WithoutEq, TestEqInstances |
There was a problem hiding this comment.
What are these instances used for? I thought we were defining explicit instances for everything in ADTS?
There was a problem hiding this comment.
We have the EqInstances separately to be able to test Eq without interference 🐔 🥚
| import org.scalacheck.{Arbitrary, Cogen, Gen} | ||
| import scala.annotation.tailrec | ||
|
|
||
| object ADTs: |
There was a problem hiding this comment.
So are we dropping testing for sealed traits in favour of enums? I had assumed that we would test both (although that sucks 😂 )
There was a problem hiding this comment.
We're not dropping anything 🤔 - we just add more tests
|
Thank you for all this work 😍 ! New milestone coming out soon? |
We're aiming for at least an RC if not full release ASAP :) |
Unfortunately there is some code duplication because I didn't find a way to make this generic.
But the boilerplate is minimal because we just wrap existing ADTs into a sort of newtype case class.
Closes #425 by making sure it works for all type classes