Add PagingSelfAwareStructuredLogger #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
requested changes
Nov 9, 2021
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Outdated
Show resolved
Hide resolved
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Outdated
Show resolved
Hide resolved
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Outdated
Show resolved
Hide resolved
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Outdated
Show resolved
Hide resolved
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Outdated
Show resolved
Hide resolved
…areStructuredLogger.scala Co-authored-by: Ross A. Baker <ross@rossabaker.com>
…areStructuredLogger.scala Co-authored-by: Ross A. Baker <ross@rossabaker.com>
Use String.slice instead of substring so no need to check end index.
Update PagingSelfAwareStructuredLogger.scala to use String.slice instead of substring
rossabaker
reviewed
Dec 6, 2021
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Outdated
Show resolved
Hide resolved
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Outdated
Show resolved
Hide resolved
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Show resolved
Hide resolved
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Outdated
Show resolved
Hide resolved
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Outdated
Show resolved
Hide resolved
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Outdated
Show resolved
Hide resolved
core/shared/src/main/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLogger.scala
Show resolved
Hide resolved
… but module support is disabled
rossabaker
reviewed
Jan 12, 2022
There was a problem hiding this comment.
Main code is looking good. I have one remaining concern with effa481.
...shared/src/test/scala/org/typelevel/log4cats/PagingSelfAwareStructuredLoggerTestRunner.scala
Outdated
Show resolved
Hide resolved
|
Seems like we can have this for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PagingSelfAwareStructuredLogger.