Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to sbt-typelevel #182

Merged
merged 8 commits into from
Feb 16, 2022
Merged

Conversation

armanbilge
Copy link
Member

Fixes #131. Supersedes #135.

MiMa is currently disabled, is this intentional?

@danicheg
Copy link
Member

MiMa is currently disabled, is this intentional?

It isn't desirable, even if it was intentional, I opine.

@armanbilge
Copy link
Member Author

It isn't desirable, even if it was intentional, I opine.

Agree :) you should remove the following settings then. I propose you do that in a follow-up PR, because there may be many MiMa problems to investigate since it was not being checked.

mimaPreviousArtifacts := Set.empty

mimaPreviousArtifacts := Set.empty

@danicheg
Copy link
Member

I agree that MiMa enabling isn't a topic of current PR. Though it's good to get what others think about it.

@armanbilge
Copy link
Member Author

We just got conflicts :( any hope to merge this?

Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR had waited for review pretty long and anybody who wanted to check it could do it. In my judgment, I don't see any blockers to don't merge that. Thanks, @armanbilge!

@danicheg danicheg merged commit 8bf436e into typelevel:main Feb 16, 2022
@armanbilge armanbilge mentioned this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non release builds published to Maven
2 participants