Add support for span suppression and coalescing, simplify span creation API via builder pattern #665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea I've been thinking about for a while. Could be useful to suppress span creation from a third party library (e.g. skunk).
The above would result in all Skunk spans getting ignored entirely and all fields / events / errors ignored.
Span.Options.Coalesce
would instead merge all the fields / events / errors to thegetOrders
span.Suppression / filtering can be done by various backends but not all. The approach in this PR allows application developers to opt-out of tracing done by a library, without requiring backend specific filtering.
This PR also switches to using the builder pattern for span creation, as otherwise we'll keep having to add various permutations of parameters to new span methods, each which breaks binary compatibility.