SpanProcessor - rethrow a composite failure on multiple errors
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
force-pushed
the
sdk-trace/span-processor-update
branch
from
5aef86d to
92463d7
Compare
iRevive
force-pushed
the
sdk-trace/span-processor-update
branch
from
92463d7 to
b57c2da
Compare
armanbilge
reviewed
Nov 27, 2023
| * the error occurred | ||
| */ | ||
| final case class ProcessorFailure(processor: String, failure: Throwable) | ||
| extends Throwable( |
There was a problem hiding this comment.
should it extend RuntimeException or even just Exception?
There was a problem hiding this comment.
It can extend Exception
NthPortal
approved these changes
Nov 28, 2023
| .parTraverse { p => | ||
| p.onStart(parentCtx, span).attempt.tupleLeft(p.name) | ||
| } | ||
| .flatMap(attempts => handleAttempts(attempts)) |
There was a problem hiding this comment.
this is a bit nitpicky (also below), but
Suggested change
| .flatMap(attempts => handleAttempts(attempts)) | |
| .flatMap(handleAttempts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #374 (comment)