sdk-exporter: allow passing a custom client to the OtlpSpanExporterAutoConfigure
#578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
added
the
module:sdk:exporter
iRevive
commented
Apr 1, 2024
| * @param client | ||
| * the custom http4s client to use | ||
| */ | ||
| def customClient[ |
There was a problem hiding this comment.
customClient vs overloaded apply 🤔
|
@hygt could you take a look, please? Will this API work for your use cases? import java.net.{InetSocketAddress, ProxySelector}
import java.net.http.HttpClient
import org.http4s.jdkhttpclient.JdkHttpClient
val jdkHttpClient = HttpClient
.newBuilder()
.proxy(ProxySelector.of(InetSocketAddress.createUnresolved("localhost", 3312)))
.build()
OpenTelemetrySdk.autoConfigured[IO](
_.addSpanExporterConfigurer(
OtlpSpanExporterAutoConfigure.customClient[IO](JdkHttpClient(jdkHttpClient))
)
).use { sdk =>
...
} |
iRevive
force-pushed
the
sdk-exporter/otlp-custom-client
branch
from
10d4f2b
to
7c8fe64
Compare
iRevive
changed the title
OtlpHttpClientOtlpSpanExporterAutoConfigure
|
Hi @iRevive sorry for not getting back to you quicker, I kinda missed the notification. I published your branch locally to try it out in a real app using Skunk, this fulfills my needs perfectly. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.