Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk-metrics: add Aggregation #594

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Apr 13, 2024

Reference Link
Spec https://opentelemetry.io/docs/specs/otel/metrics/sdk/#aggregation
Java implementation Aggregation.java

Unlike otel-java, we will split Aggregation and Aggregator. In other words, Aggregation defines only the aggregation strategy, and that's it.

P.S. Base2ExponentialBucketHistogram is missing because I haven't implemented an aggregator for this strategy yet. I will add it later.

@iRevive iRevive added metrics Improvement to metrics module module:sdk Features and improvements to the sdk module labels Apr 13, 2024
@iRevive iRevive requested a review from NthPortal April 13, 2024 12:00
@iRevive iRevive merged commit 65e3322 into typelevel:main Apr 16, 2024
10 checks passed
@iRevive iRevive deleted the sdk-metrics/aggregation branch April 16, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Improvement to metrics module module:sdk Features and improvements to the sdk module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant