Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalafmt: set maxColumn = 120 #766

Merged
merged 2 commits into from
Sep 11, 2024
Merged

scalafmt: set maxColumn = 120 #766

merged 2 commits into from
Sep 11, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Sep 10, 2024

Plenty of projects use maxColumn = 120: #761 (comment).

And the content fits the 14" display.

mzuehlke
mzuehlke approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1300 lines less code.
Most formatting changes are in the docs actually.
Looks good 😄

@iRevive iRevive merged commit ed30ddb into typelevel:main Sep 11, 2024
10 checks passed
@iRevive iRevive deleted the scalafmt-maxColumn branch September 11, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzuehlke mzuehlke mzuehlke approved these changes

@NthPortal NthPortal Awaiting requested review from NthPortal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iRevive @mzuehlke