Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk-exporter-prometheus: unify PrometheusWriter.Config options #810

Merged
merged 1 commit into from
Oct 24, 2024
Merged

sdk-exporter-prometheus: unify PrometheusWriter.Config options #810

merged 1 commit into from
Oct 24, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Oct 23, 2024

A bit of unification of the config properties:

  • noUnits -> unitSuffixDisabled
  • noTypeSuffixes -> typeSuffixDisabled
  • disabledScopeInfo -> scopeInfoDisabled
  • disabledTargetInfo -> targetInfoDisabled

@iRevive iRevive added the module:sdk Features and improvements to the sdk module label Oct 23, 2024
@iRevive iRevive merged commit f3d9f98 into typelevel:main Oct 24, 2024
8 of 10 checks passed
@iRevive iRevive deleted the sdk-exporter/prometheus-writer-config branch October 24, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:sdk Features and improvements to the sdk module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iRevive