-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tlVersionIntroduced as a function of scalaVersion #24
Comments
I was thinking like: .settings(
tlVersionIntroduced := {
if (tlIsScala3.value) Some("1.1.4") else None
}
) But, maybe not for everyone. BTW, the mdoc build has a scalacOptions ++= crossSetting(
scalaVersion.value,
if2 = List("-target:jvm-1.8", "-Yrangepos", "-deprecation"),
if212 = List("-Xexperimental"),
if211 = List("-Xexperimental"),
if3 = List("-language:implicitConversions", "-Ximport-suggestion-timeout", "0")
) |
Yeah, the |
I don't know without looking whether sbt-spiewak is a function or a map. Maybe a function is more power than is needed. I've always provided a map. |
Yeah, I'm working on this now and I remembered why I don't like it: Scala version parsing from
Or a solution like the Edit: spiewak just expects binary version, so it would be |
case-insensitive needed the RCs because it was checking old versions, but we could have just turned it off for Scala 3. I removed it entirely in typelevel/case-insensitive#208. I don't like the case class, because that bundles binary compatibility of this plugin with the set of Scala versions supported today. |
Oh, here's one more layer of complexity: now that we are checking MiMa for Scala.js and native as well, we also need to consider that axis, since these crosses were introduced later for some projects/modules. I guess that can be handled by defining a separate |
After questioning life choices that brought me to that point, I'd do separate |
Modules get introduced in different versions for different crossbuilds. sbt-spiewak takes a function of Scala versions to version introduced:
I'm not sure how we express that in
tlVersionIntroduced
.The text was updated successfully, but these errors were encountered: