Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show seed for failing property check #446

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

ryanpbrewster
Copy link
Contributor

This copies the current behavior of propertyWithSeed(..., None) into property(...)

This copies the current behavior of `propertyWithSeed(..., None)` into `property(...)`
@ryanpbrewster
Copy link
Contributor Author

I believe this will address #400

@SethTisue
Copy link
Member

rebase?

@ryanpbrewster
Copy link
Contributor Author

done

@SethTisue
Copy link
Member

is someone knowledgeable enough to review this?

@ashawley
Copy link
Contributor

ashawley commented Aug 9, 2019

It looks good to me, but @non is the seed expert.

@ryanpbrewster
Copy link
Contributor Author

Note for reviewer: this is basically copy-pasting the implementation from L111, the PropertyWithSeedSpecifier class. This class will always show the seed for a failing test case.

((Effectively the only change here is adding a call to .viewSeed(fullName) to the end of Prop.delay(p). Let me know if there's anything else I can add here.))

@SethTisue
Copy link
Member

SethTisue commented Aug 16, 2019

perhaps add a test that illustrates the purpose of the change...?

@ashawley ashawley merged commit b6bf677 into typelevel:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants