-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add relations option to tree queries #7981
Conversation
remove unused declaration to satisfy linting.
docs: rename variable for copy paste
style: remove prettified code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to update the files manually because deactivating prettifier didn't change anything automatically. Could you please add the information to the development/contribution guide?
Everything should be updated as requested now!
@pleerock / @imnotjames Can this functionality be merged now? |
Thank you for contribution! 🎉 |
@pleerock / @imnotjames Do you have any prediction of when this will be released? |
could the same options be added to |
findDescendantsTree also has this property since this pull request - the other 2 not. You can create an issue for those 2. |
Created: #8076 |
there is no |
Add possibility to load relations of tree entities
Description of change
The change adds an optional
options
parameter to the findTrees() function.The only option that can currently be set is
relations
which is an array of all relations that should be loaded for the entities. It works the same way as therelations
array for the find() method.Example:
Results in:
Because findTrees() is depending on the findDescendantsTree() and findRoots() functions those two also implement this new optional
options
parameter.Currently it is not possible to load relations for tree entities in a single query. This is a much requested and needed feature, it would be great if it could be merged very soon!
I created test cases to ensure the functionality.
Closes: #7974 #4564
Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000
Could you please tell me when you are planning to merge this pull request? Thank you!