Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relation options to all tree queries (missing ones) #8076

Closed
spiotr12 opened this issue Aug 13, 2021 · 1 comment · Fixed by #8080
Closed

Add relation options to all tree queries (missing ones) #8076

spiotr12 opened this issue Aug 13, 2021 · 1 comment · Fixed by #8080
Labels
new feature requires triage

Comments

@spiotr12
Copy link

Feature Description

Add relation options to all tree queries (missing ones)

The Problem

This PR did introduce a FindTreeOptions to some of the find* methods. However there are 3 methods that did not got these options:

  • findDescendants
  • findAncestors
  • findAncestorsTree

The Solution

Could this be also added?

Considered Alternatives

Additional Context

So then used tree repository and finding ancestors, descendants in flat or tree structure, the relations are loaded as well (or selected to be loaded)

Relevant Database Driver(s)

I think it relates to repository - not to a specific driver

DB Type Relevant
aurora-data-api no
aurora-data-api-pg no
better-sqlite3 no
cockroachdb no
cordova no
expo no
mongodb no
mysql no
nativescript no
oracle no
postgres no
react-native no
sap no
sqlite no
sqlite-abstract no
sqljs no
sqlserver no

Are you willing to resolve this issue by submitting a Pull Request?

  • ✖️ Yes, I have the time, and I know how to start.
  • ✖️ Yes, I have the time, but I don't know how to start. I would need guidance.
  • ✖️ No, I don’t have the time, but I can support (using donations) development.
  • ✅ No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.
@spiotr12 spiotr12 mentioned this issue Aug 13, 2021
Merged
7 tasks
@TheProgrammer21
Copy link
Contributor

I just implemented this issue - pull request comes in a minute.

@TheProgrammer21 TheProgrammer21 mentioned this issue Aug 13, 2021
Merged
7 tasks
pleerock pushed a commit that referenced this issue Nov 8, 2021
@TheProgrammer21
feat: add relation options to all tree queries (#8080)
e4d4636 
* feat: add relation options to all tree queries

Closes: #8076

* fix: corrected array index in test case

* try to fix failing test

* fix: sort the array in order to be able to apply tests
HeartPattern pushed a commit to HeartPattern/typeorm that referenced this issue Nov 29, 2021
@TheProgrammer21 @HeartPattern
feat: add relation options to all tree queries (typeorm#8080)
f48a860 
* feat: add relation options to all tree queries

Closes: typeorm#8076

* fix: corrected array index in test case

* try to fix failing test

* fix: sort the array in order to be able to apply tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature requires triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add relation options to all tree queries
2 participants
@spiotr12 @TheProgrammer21