fix(eslint-plugin): [no-deprecated] report on deprecated variables us…

…ed in destructuring assignment (#9978)
typescript-eslint · Sep 13, 2024 · 9a80067 · 9a80067
1 parent 2d6872a
commit 9a80067
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 4 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-deprecated.ts b/packages/eslint-plugin/src/rules/no-deprecated.ts
@@ -193,10 +193,7 @@ export default createRule({
     function getSymbol(
       node: IdentifierLike,
     ): ts.Signature | ts.Symbol | undefined {
-      if (
-        node.parent.type === AST_NODE_TYPES.AssignmentPattern ||
-        node.parent.type === AST_NODE_TYPES.Property
-      ) {
+      if (node.parent.type === AST_NODE_TYPES.Property) {
         return services
           .getTypeAtLocation(node.parent.parent)
           .getProperty(node.name);

diff --git a/packages/eslint-plugin/tests/rules/no-deprecated.test.ts b/packages/eslint-plugin/tests/rules/no-deprecated.test.ts
@@ -295,6 +295,38 @@ ruleTester.run('no-deprecated', rule, {
         },
       ],
     },
+    {
+      code: `
+        /** @deprecated */ const a = { b: 1 };
+        const { c = a } = {};
+      `,
+      errors: [
+        {
+          column: 21,
+          endColumn: 22,
+          line: 3,
+          endLine: 3,
+          data: { name: 'a' },
+          messageId: 'deprecated',
+        },
+      ],
+    },
+    {
+      code: `
+        /** @deprecated */ const a = { b: 1 };
+        const [c = a] = [];
+      `,
+      errors: [
+        {
+          column: 20,
+          endColumn: 21,
+          line: 3,
+          endLine: 3,
+          data: { name: 'a' },
+          messageId: 'deprecated',
+        },
+      ],
+    },
     {
       code: `
         /** @deprecated */ const a = { b: 1 };